REF: cython cleanup, typing, optimizations #23464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Nov 2, 2018
| @@ -259,7 +259,7 @@ def ismember_{{dtype}}({{scalar}}[:] arr, {{scalar}}[:] values): | |||
| {{if dtype == 'object'}} | |||
| for i in range(n): | |||
| val = arr[i] | |||
| k = kh_get_{{ttype}}(table, <PyObject*> val) | |||
| k = kh_get_{{ttype}}(table, <PyObject*>val) | |||
There was a problem hiding this comment.
are actually linting this? iirc these were changed to add the space last year. i don’t care which way but we should have 1 true way
There was a problem hiding this comment.
I'm not aware of a way to lint for this.
I've been pretty consistent about no-space, so at this point that constitutes a pretty large majority of existing cases.
| cimport cython | ||
| from cython cimport Py_ssize_t | ||
| import cython | ||
| from cython import Py_ssize_t |
There was a problem hiding this comment.
No. Only difference is one is valid python, getting us one step closer to being able to lint
| return util.is_integer_object(obj) | ||
|
|
||
|
|
||
| def is_bool(obj: object) -> bint: | ||
| def is_bool(obj: object) -> bool: |
There was a problem hiding this comment.
why are these changing? what is wrong with bint?
There was a problem hiding this comment.
nothing is wrong with bint, but part of the upside of using py3-annotations is that its valid python. using bint instead of bool defeats that purpose
|
Travis failure is for (new?) linting in docs/ and scripts/ |
This was referenced Nov 3, 2018
jreback
approved these changes
Nov 3, 2018
|
thanks |
thoo
added a commit
to thoo/pandas
that referenced
this pull request
Nov 3, 2018
…xamples * repo_org/master: (66 commits) CLN: doc string (pandas-dev#23469) DOC: Add cookbook entry for triangular correlation matrix (GH22840) (pandas-dev#23032) add number of Errors, Warnings to scripts/validate_docstrings.py (pandas-dev#23150) BUG: Allow freq conversion from dt64 to period (pandas-dev#23460) ENH: Add FrozenList.union and .difference (pandas-dev#23394) REF: cython cleanup, typing, optimizations (pandas-dev#23464) strictness and checks for Timedelta _simple_new (pandas-dev#23433) Fixing flake8 problems new to flake8 3.6.0 (pandas-dev#23472) DOC: Updating the docstring of Series.dot (pandas-dev#22890) TST: Fixturize series/test_analytics.py (pandas-dev#22755) BUG/ENH: Handle NonexistentTimeError in date rounding (pandas-dev#23406) PERF: speed up concat on Series by making _get_axis_number() a classmethod (pandas-dev#23404) REF: Remove DatetimelikeArrayMixin._shallow_copy (pandas-dev#23430) REF: strictness/simplification in DatetimeArray/Index _simple_new (pandas-dev#23431) REF: cython cleanup, typing, optimizations (pandas-dev#23456) TST: tweak Hypothesis configuration and idioms (pandas-dev#23441) BUG: fix HDFStore.append with all empty strings error (GH12242) (pandas-dev#23435) TST: Skip 32bit failing IntervalTree tests (pandas-dev#23442) BUG: Deprecate nthreads argument (pandas-dev#23112) style: fix import format at pandas/core/reshape (pandas-dev#23387) ...
JustinZhengBC
pushed a commit
to JustinZhengBC/pandas
that referenced
this pull request
Nov 14, 2018
* Easy bits of pandas-dev#23382 * Easy parts of pandas-dev#23368
tm9k1
pushed a commit
to tm9k1/pandas
that referenced
this pull request
Nov 19, 2018
* Easy bits of pandas-dev#23382 * Easy parts of pandas-dev#23368
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
* Easy bits of pandas-dev#23382 * Easy parts of pandas-dev#23368
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
* Easy bits of pandas-dev#23382 * Easy parts of pandas-dev#23368
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splitting out more easy parts of #23382, #23368